[FEATURE] get-manifest hook should remove protocol from outgoingDomains
if present
#95
Labels
enhancement
New feature or request
outgoingDomains
if present
#95
Very annoying sharp edge: if you happen to include the protocol in
outgoingDomain
entries, you will get a cryptic error message when you go to deploy or run your app:In this case, I had
outgoingDomains: ['https://google.com']
in my manifest. Droppinghttps://
fixes the issue.My suggested solution is for the get-manifest hook to parse these entries using the
URL
module, and extract only the hostname, dropping protocol. Feels like it belongs squarely in thecleanManifest
function of theget-manifest
hook.The text was updated successfully, but these errors were encountered: