Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement auto_acknowledge feature for socket clients. #1300

Closed
wants to merge 4 commits into from
Closed

Implement auto_acknowledge feature for socket clients. #1300

wants to merge 4 commits into from

Conversation

amshamah419
Copy link

@amshamah419 amshamah419 commented Nov 14, 2022 •
edited
Loading

Summary

The goal is to allow the Socket Mode Client to automatically send the acknowledgment notification to reduce the likelihood that a message could expire while waiting in the event queue.

The default is currently False to prevent any backwards compatibility issues.

fixes: #1299

Category (place an x in each of the [ ])

  • slack_sdk.web.WebClient (sync/async) (Web API client)
  • slack_sdk.webhook.WebhookClient (sync/async) (Incoming Webhook, response_url sender)
  • slack_sdk.socket_mode (Socket Mode client)
  • slack_sdk.signature (Request Signature Verifier)
  • slack_sdk.oauth (OAuth Flow Utilities)
  • slack_sdk.models (UI component builders)
  • slack_sdk.scim (SCIM API client)
  • slack_sdk.audit_logs (Audit Logs API client)
  • slack_sdk.rtm_v2 (RTM client)
  • /docs-src (Documents, have you run ./scripts/docs.sh?)
  • /docs-src-v2 (Documents, have you run ./scripts/docs-v2.sh?)
  • /tutorial (PythOnBoardingBot tutorial)
  • tests/integration_tests (Automated tests for this library)

Requirements (place an x in each [ ])

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.sh after making the changes.

@CLAassistant
Copy link

CLAassistant commented Nov 14, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@seratch seratch self-assigned this Nov 14, 2022
@seratch seratch added enhancement M-T: A feature request for new functionality Version: 3x socket-mode labels Nov 14, 2022
@seratch seratch added this to the 3.x milestone Nov 14, 2022
@seratch seratch marked this pull request as draft November 14, 2022 22:19
@seratch
Copy link
Member

seratch commented Nov 14, 2022

Hi @amshamah419, thanks for sending this! But for the reasons that I mentioned at #1299 (comment), we would like to hold off working on the details of this PR at this moment.

@seratch
Copy link
Member

seratch commented Feb 17, 2023

Thanks again for sending this PR! but for the reason I mentioned above, we are not planning to add this flag at least in the short term. So, let us close this issue now. It'd be appreciated if you could understand this.

@seratch seratch closed this Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@seratch seratch

Labels
enhancement M-T: A feature request for new functionality socket-mode Version: 3x
Projects
None yet
Milestone
3.x
Development

Successfully merging this pull request may close these issues.

Add param to enable "Auto-Acknowledgment" of Events to the SocketModeClient
3 participants
@amshamah419 @CLAassistant @seratch