Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why are deprecated methods not commented out or removed? #1531

Open
Keanro opened this issue Jul 17, 2024 · 1 comment
Open

Why are deprecated methods not commented out or removed? #1531

Keanro opened this issue Jul 17, 2024 · 1 comment

Comments

@Keanro
Copy link

Keanro commented Jul 17, 2024

Is there a reason that deprecated methods, such as groups_createChild, are allowed to be called? As the deprecation happened 3.5 years ago, it feels like it's a good time to comment them out or remove it. An old issue had a similar question, but it's not quite the same question.

def groups_createChild(
self,
*,
channel: str,
**kwargs,
) -> SlackResponse:
"""Clones and archives a private channel."""
kwargs.update({"channel": channel})
return self.api_call("groups.createChild", http_verb="GET", params=kwargs)

@seratch seratch added this to the 3.x milestone Jul 18, 2024
@seratch
Copy link
Member

seratch commented Jul 18, 2024

Hi @Keanro, thanks for the suggestion! Indeed, there are no blockers for removing them, so we may remove the lines of code in a future release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants