Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

n_read in full_band_ampl_sweep is not used #638

Open
eyyoung24 opened this issue Apr 28, 2021 · 0 comments
Open

n_read in full_band_ampl_sweep is not used #638

eyyoung24 opened this issue Apr 28, 2021 · 0 comments
Labels
bug Something isn't working SLAC

Comments

@eyyoung24
Copy link
Contributor

Describe the bug

pysmurf/python/pysmurf/client/tune/smurf_tune.py

Line 3573 in b95a6dc

def full_band_ampl_sweep(self, band, subband, tone_power, n_read, n_step=31):

The variable n_read does not actually do anything. We need to add this functionality.

To Reproduce

Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior

A clear and concise description of what you expected to happen.

Additional details

Add any other details about the problem here.
@eyyoung24 eyyoung24 added the bug Something isn't working label Apr 28, 2021
@agustiner agustiner added the SLAC label Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working SLAC
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@eyyoung24 @agustiner