Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lms_gain default setting not zero #660

Open
zhuber21 opened this issue Jun 9, 2021 · 2 comments
Open

lms_gain default setting not zero #660

zhuber21 opened this issue Jun 9, 2021 · 2 comments
Labels
bug Something isn't working mustfix Must fix this. SO waiting-on-other-fixes Depends on fixing something else (like a JIRA).

Comments

@zhuber21
Copy link

zhuber21 commented Jun 9, 2021

Describe the bug

Right now, if you don't supply the lms_gain parameter to tracking_setup(), it defaults to None and then uses the code

if lms_gain is None:
    lms_gain = int(9 - np.ceil(np.log2(100/reset_rate_khz)))

to set it to four. Since we are supposed to be setting it to zero right now, having the default be something other than zero caused problems during our testing. As long as lms_gain is supposed to be set to zero, Shawn suggests that the default should be zero to avoid mistakes.

@zhuber21 zhuber21 added the bug Something isn't working label Jun 9, 2021
@zhuber21
Copy link
Author

zhuber21 commented Jun 9, 2021

This is related to the issue Daniel brought up in https://github.com/simonsobs/smurf-issues/issues/36

@swh76
Copy link
Collaborator

swh76 commented Sep 14, 2021

This is related to JIRA https://jira.slac.stanford.edu/browse/ESCRYODET-825. Need to fix that first.

@swh76 swh76 added the waiting-on-other-fixes Depends on fixing something else (like a JIRA). label Sep 14, 2021
@agustiner agustiner added the SO label Nov 5, 2021
@agustiner agustiner added the mustfix Must fix this. label Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working mustfix Must fix this. SO waiting-on-other-fixes Depends on fixing something else (like a JIRA).
Projects
None yet
Development

No branches or pull requests

3 participants