Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix read_ac_dc_relay_status #711

Open
agustiner opened this issue Mar 4, 2022 · 0 comments
Open

Fix read_ac_dc_relay_status #711

agustiner opened this issue Mar 4, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@agustiner
Copy link
Member

read_ac_dc_relay_status has bugs:

  • The docstring says its DC coupled (shorted) when the relay bit is 0, which is wrong.
  • Other parts of pysmurf expect either the value 0 or 3 (0b11), but it currently returns only 0 and 1 because its reading another register.

Please again confirm that 0x08 doesn't actually do anything on the C04 cryocard, because this is how we previously read out the flux ramp coupling status for both relays on the C02, hence the value of 3, 0b11. Ref https://github.com/slaclab/smurfc/blob/C04/README.SpiRegisterMap.md.

@agustiner agustiner added the bug Something isn't working label Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant