Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove errant factor of 4 in smurf_control.setup() call to set_lms_delay() #789

Open
swh76 opened this issue Mar 25, 2024 · 0 comments
Open
Assignees
Labels
bug Something isn't working

Comments

@swh76
Copy link
Collaborator

swh76 commented Mar 25, 2024

Description of this problem in simonsobs/sodetlib#423. The factor of 4 here -

band, int(4*self._ref_phase_delay[band]),
needs to be removed; older SMuRF firmware versions used to process four tones in every polyphase filter bank (PFB) subband, but the production firmware we use now processes only one tone in every PFB subband. The 4* was only relevant for older versions of the firmware where there was more delay due to each subband needing to do four times more processing.

This bug prevents users from properly setting the lmsDelay from their pysmurf cfg file (since it gets multiplied by this hidden 4 and then usually overflows the lmsDelay register under the hood, causing it to error out and be zero). lmsDelay is a very important parameter required for tracking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant