-
-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align with native Unicode property escapes #225
Comments
Supporting The other changes (dropping support for loose name matching and Aside: While we're considering breaking changes for the Unicode addons, perhaps we should move |
Removed support for Unicode blocks in commit 4860122. |
Changes include: * BREAKING: Handle ES2018 capture names: #247 * BREAKING: Enable `namespacing` feature by default: #316 * BREAKING: Remove Unicode Blocks addon: 4860122 * restore perf tweak that made a meaningful difference in regex construction perf tests: 5f18261 * XRegExp.exec: preserve groups obj that comes from native ES2018 named capture: c4a83e7 * Make XRegExp.exec set groups prop to undefined if there are no named captures (closes #320): 7fea476 * Support optional 'Script=' prefix (from ES2018 syntax) for Unicode script tokens (#225): bb35ead * XRegExp.matchRecursive: Add delimiter and pos info when unbalanced delimiters are found (closes #293): 9660b90 * XRegExp.escape: Escape whitespace in a way that works with ES6 flag u (fixes #197): e22a52b To generate this commit, I adapted the steps at #205 (comment) Here's a fuller list of changes that can be needed with new releases: > * Version number > * Update version number and year in headers, config files, README. > * Update version number in `XRegExp.version`. > * Publish > * Publish new git tag. E.g.: > * `git tag -a v3.1.0 -m "Release 3.1.0"`. > * `git push origin v3.1.0`. > * `npm publish`.
Changes include: * BREAKING: Handle ES2018 capture names: #247 * BREAKING: Enable `namespacing` feature by default: #316 * BREAKING: Remove Unicode Blocks addon: 4860122 * restore perf tweak that made a meaningful difference in regex construction perf tests: 5f18261 * XRegExp.exec: preserve groups obj that comes from native ES2018 named capture: c4a83e7 * Make XRegExp.exec set groups prop to undefined if there are no named captures (closes #320): 7fea476 * Support optional 'Script=' prefix (from ES2018 syntax) for Unicode script tokens (#225): bb35ead * XRegExp.matchRecursive: Add delimiter and pos info when unbalanced delimiters are found (closes #293): 9660b90 * XRegExp.escape: Escape whitespace in a way that works with ES6 flag u (fixes #197): e22a52b To generate this commit, I adapted the steps at #205 (comment) Here's a fuller list of changes that can be needed with new releases: > * Version number > * Update version number and year in headers, config files, README. > * Update version number in `XRegExp.version`. > * Publish > * Publish new git tag. E.g.: > * `git tag -a v3.1.0 -m "Release 3.1.0"`. > * `git push origin v3.1.0`. > * `npm publish`.
Other than the set of supported properties, there are some key differences between XRegExp’s handling of
\p{…}
and the way they work in native JS.\p{…}
doesn’t implement loose matching; only strict, case-sensitive matches for canonical property names and values (or their aliases) are accepted\p{…}
,Block
s are not supported\p{…}
doesn’t support for theIn
prefix or any other prefix (although since XRegExp only does this forBlock
s, droppingBlock
support already resolves this)\p{…}
supportsScript_Extensions
which is generally more useful thanScript
Technically these are all breaking changes, but IMHO we should consider aligning with native property escapes.
The text was updated successfully, but these errors were encountered: