Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marge fails too hard on network errors #314

Open
raphael-proust opened this issue Jun 14, 2021 · 1 comment · Fixed by hiboxsystems/marge-bot#4
Open

Marge fails too hard on network errors #314

raphael-proust opened this issue Jun 14, 2021 · 1 comment · Fixed by hiboxsystems/marge-bot#4

Comments

@raphael-proust
Copy link

When margebot encounters a network error during the merging process (e.g., timeout when checking the CI status), it fails hard and adds a "I'm broken inside" comment. Because network errors can be transient, margebot should retry failed network requests.

I can try to make a PR for this, but I have the following questions:

  • Do you agree with the diagnostic and with the main proposal?

  • I'm not sure where to make the necessary modifications in the code. Specifically, I'm not sure what granularity to have:

    • At the high-level of single_merge_job's execute: we won't miss any errors (at least not during the merging process)?
    • At a lower level (fetch_approvals and update_merge_request_and_accept or even lower): we have more specific context for what stage failed?
    • At a higher level (outside of single_merge_job)?
    • At a different level altogether such as by patching the self._api object or changing some configuration of the underlying http request library.
@xtermi2
Copy link

xtermi2 commented Sep 11, 2022

Yes, please add this feature! Would save us a lot of work!

slovdahl pushed a commit to hiboxsystems/marge-bot that referenced this issue Dec 20, 2022
slovdahl pushed a commit to hiboxsystems/marge-bot that referenced this issue Dec 20, 2022
slovdahl pushed a commit to hiboxsystems/marge-bot that referenced this issue Dec 21, 2022
perlun pushed a commit to hiboxsystems/marge-bot that referenced this issue Dec 21, 2022
slovdahl pushed a commit to hiboxsystems/marge-bot that referenced this issue Dec 21, 2022
slovdahl pushed a commit to hiboxsystems/marge-bot that referenced this issue Dec 21, 2022
slovdahl pushed a commit to hiboxsystems/marge-bot that referenced this issue Dec 21, 2022
slovdahl pushed a commit to hiboxsystems/marge-bot that referenced this issue Dec 21, 2022
slovdahl pushed a commit to hiboxsystems/marge-bot that referenced this issue Dec 21, 2022
slovdahl pushed a commit to hiboxsystems/marge-bot that referenced this issue Dec 21, 2022
slovdahl pushed a commit to hiboxsystems/marge-bot that referenced this issue Dec 21, 2022
slovdahl pushed a commit to hiboxsystems/marge-bot that referenced this issue Dec 22, 2022
slovdahl pushed a commit to hiboxsystems/marge-bot that referenced this issue Apr 20, 2023
slovdahl pushed a commit to hiboxsystems/marge-bot that referenced this issue Apr 20, 2023
slovdahl pushed a commit to hiboxsystems/marge-bot that referenced this issue Apr 20, 2023
slovdahl added a commit to hiboxsystems/marge-bot that referenced this issue Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants