-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Marge fails too hard on network errors #314
Comments
Yes, please add this feature! Would save us a lot of work! |
slovdahl
added a commit
to hiboxsystems/marge-bot
that referenced
this issue
Apr 20, 2023
fixes smarkets#314 Co-authored-by: z8v <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When margebot encounters a network error during the merging process (e.g., timeout when checking the CI status), it fails hard and adds a "I'm broken inside" comment. Because network errors can be transient, margebot should retry failed network requests.
I can try to make a PR for this, but I have the following questions:
Do you agree with the diagnostic and with the main proposal?
I'm not sure where to make the necessary modifications in the code. Specifically, I'm not sure what granularity to have:
single_merge_job
'sexecute
: we won't miss any errors (at least not during the merging process)?fetch_approvals
andupdate_merge_request_and_accept
or even lower): we have more specific context for what stage failed?single_merge_job
)?self._api
object or changing some configuration of the underlying http request library.The text was updated successfully, but these errors were encountered: