Add a retry mechanism on all API calls #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perlun
reviewed
Dec 21, 2022
perlun
approved these changes
Dec 21, 2022
slovdahl
force-pushed
the
network-retries
branch
from
1450558
to
ebcf5fa
Compare
perlun
approved these changes
Dec 21, 2022
perlun
force-pushed
the
network-retries
branch
from
ebcf5fa
to
d63dab7
Compare
slovdahl
force-pushed
the
network-retries
branch
from
d63dab7
to
933d402
Compare
perlun
reviewed
Dec 21, 2022
slovdahl
force-pushed
the
network-retries
branch
7 times, most recently
from
6a7fa55
to
e56ae45
Compare
|
Is here any progress? We need this retry mechanism because he have a lot of failures which could be solved by retries 🙏 |
|
Hi @xtermi2! This PR has stalled a little bit, we have not had any problems recently that would be solved by this. But I do agree it's a nice improvement in general. Overall, we're in the process of consolidating all the current and active forks of |
slovdahl
force-pushed
the
network-retries
branch
2 times, most recently
from
a4c29e8
to
b3bfb0e
Compare
slovdahl
force-pushed
the
network-retries
branch
from
b3bfb0e
to
8e65c04
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes smarkets#314
Originally submitted by @z8v in smarkets#349. Will keep it in our fork until it has been merged upstream.