Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

time_to_close.json is still including 0th ward in WardData #170

Open
santheo opened this issue Jul 29, 2013 · 4 comments
Open

time_to_close.json is still including 0th ward in WardData #170

santheo opened this issue Jul 29, 2013 · 4 comments
Assignees

Comments

@santheo
Copy link
Contributor

santheo commented Jul 29, 2013

curl http://localhost:5000/requests/time_to_close.json?count=7&service_code=4fd3b167e750846744000005&end_date=2013-05-16

{
  "WardData": {
    "0": {
      "Time": 0.00974537037037037,
      "Count": 1
    },
    "1": {
      "Time": 9.006513941099538,
      "Count": 133
    },
    "10": {
      "Time": 1.509606963738426,
      "Count": 72
    },
…
@ghost ghost assigned cgansen Jul 29, 2013
@cgansen
Copy link
Contributor

cgansen commented Jul 29, 2013

Yes. Some SR come through with nil wards, and those are attributed to ward
0 in the daily counts. The value should be discarded or ignored.

Is this breaking something?

On Mon, Jul 29, 2013 at 5:00 PM, Sandor Weisz [email protected]:

curl http://localhost:5000/requests/time_to_close.json?count=7&service_code=4fd3b167e750846744000005&end_date=2013-05-16

{
"WardData": {
"0": {
"Time": 0.00974537037037037,
"Count": 1
},
"1": {
"Time": 9.006513941099538,
"Count": 133
},
"10": {
"Time": 1.509606963738426,
"Count": 72
},


Reply to this email directly or view it on GitHubhttps://github.com//issues/170
.

[email protected]

@santheo
Copy link
Contributor Author

santheo commented Jul 29, 2013

It is. Should I strip out the 0th ward on the front-end?

@cgansen
Copy link
Contributor

cgansen commented Jul 29, 2013

Yes, Ignore it there. Keep this open as a reminder to me to remove it from the JSON, but it's not a blocker.

@santheo
Copy link
Contributor Author

santheo commented Jul 29, 2013

Done in 637b62d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants