Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

known spawning/rearing directly from FISS creates confusion regarding barrier cancellation #567

Open
smnorris opened this issue Sep 19, 2024 · 0 comments

Comments

@smnorris
Copy link
Owner

In addition to CWF and PSF sources in the known spawning/rearing dataset we now include FISS observations with salmon spawning activity. This adds value, marking "known" spawning locations in bcfishpass outputs.

However, because the model currently cancels out natural barriers downstream of any known spawning/rearing, the result can be confusing in instances of 1-4 poor quality FISS observations upstream of a barrier - only one "known spawning" observation is required to cancel the barrier (vs the expected 5 since 1990).

Consider one of:

  • do not cancel barriers just 1-4 of these records, require >5 since 1990
  • run some QA to find suspect points and remove

Either option requires a bit of work because the data is materialized in data/user_habitat_classification.csv

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant