Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment handler not serving u-in-reply-to for reply that's also @-mention #1617

Open
snarfed opened this issue Nov 21, 2023 · 2 comments
Open
Labels

Comments

@snarfed
Copy link
Owner

snarfed commented Nov 21, 2023

Originally posted by @snarfed in aaronpk/webmention.io#187 (comment):

Not entirely sure what's going on here, but I suspect the problem is we're finding that post at least two different ways, as a downstream reply and as an @-mention, and we're not merging the two versions. Eg we sent this webmention for the reply, but when webmention.io fetches the source page, we render it as the @-mention, so it doesn't have u-in-reply-to pointing to https://joshuawood.net/webmentions .

I thought we fixed this a long time ago, in #533 and a10a5a1, but maybe not, or maybe not all variations. Will look. I suspect this one is tricky though, no promises.

@snarfed
Copy link
Owner Author

snarfed commented Nov 21, 2023

Original report from @joshuap in aaronpk/webmention.io#187 (comment) :

{
  "status": "no_link_found",
  "source": "https://brid.gy/comment/mastodon/@[email protected]/111439777418267489/111439855894516928",
  "target": "https://joshuawood.net/webmentions",
  "summary": "The Microformats at the source URL do not contain a link to the target URL. Check the source URL in a Microformats parser such as php.microformats.io"
}

It's strange because it accepted the reply that this was in response to, but it won't accept this one. I check the microformats on php.microformats.io as suggested, and it parsed the source URL just fine afaict:

http://php.microformats.io/?url=https%3A%2F%2Fbrid.gy%2Fcomment%2Fmastodon%2F%40wood%40hachyderm.io%2F111439777418267489%2F111439855894516928

@snarfed
Copy link
Owner Author

snarfed commented Jan 5, 2024

pfefferle/wordpress-webmention#454 (comment) may be an instance of this without an @-mention. @jaschaurbach posted a top-level post, then a reply to a reply, and then someone else's reply to that is similarly missing the u-in-reply-to to the top-level post's original post.

The root problem here, or at least one, is that https://brid.gy/comment/mastodon/@[email protected]/111681444048580159/111681453109020359 should have u-in-reply-to link pointing to https://jascha.wtf/angels-at-chaos-about-volunteering-and-fitting-in/ , but doesn't.

That post is both a direct reply to https://chaos.social/@[email protected]/111681444071267594 and an indirect reply to the root post https://chaos.social/@[email protected]/111679915834398325 . The original post https://jascha.wtf/angels-at-chaos-about-volunteering-and-fitting-in/ is in the latter. Bridgy should still find it, but my guess is that the immediate parent is overriding it somehow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant