Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encrypt (with salt) tokens in datastore #1647

Open
snarfed opened this issue Jan 19, 2024 · 0 comments
Open

Encrypt (with salt) tokens in datastore #1647

snarfed opened this issue Jan 19, 2024 · 0 comments

Comments

@snarfed
Copy link
Owner

snarfed commented Jan 19, 2024

We should encrypt (with salt) the tokens in the datastore, with a static key deployed with the app. Tokens are already encrypted at rest, and this isn't a silver bullet against other attacks, but it defends against SQL injection style attacks that exfiltrate keys through the app itself. (We're not subject to SQL injection since we don't use SQL, but the broader idea still applies.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant