Skip to content
This repository has been archived by the owner on Aug 13, 2024. It is now read-only.

Add eventTime to all webhooks #95

Open
alexanderdean opened this issue Dec 29, 2016 · 4 comments
Open

Add eventTime to all webhooks #95

alexanderdean opened this issue Dec 29, 2016 · 4 comments
Milestone

Comments

@alexanderdean
Copy link
Contributor

alexanderdean commented Dec 29, 2016

As a webhook, we don't have a device sent timestamp, so we need an updateTime (or equivalent name) sent with each event.

@alexanderdean
Copy link
Contributor Author

Bringing this forward as this will really simplify @ihortom's visualization...

@alexanderdean alexanderdean assigned ungn and unassigned ninjabear Jan 26, 2017
@ninjabear
Copy link
Contributor

Hey @alexanderdean (or @ihortom) , what's the plan for the update information? When I initially wrote the webhooks I didn't include this because it seemed like you'd only ever need to know the start/end time of tasks. Based on this ticket I think there's a use case I missed?

@alexanderdean alexanderdean changed the title Add updateTime to all webhooks Add eventTime to all webhooks Jan 27, 2017
@alexanderdean
Copy link
Contributor Author

alexanderdean commented Jan 27, 2017

Hey @ninjabear - I think the name of this new field is misleading - I've updated it to eventTime.

The reason for this field is so that there is a uniform top-level field in all webhooks which indicates when the webhook event was created.

This is important because otherwise an analyst looking at these webhooks in Snowplow is left relying on webhook-specific fields or worse the collector_tstamp.

Does that make sense?

@ninjabear
Copy link
Contributor

Ah cool, yes I see what you mean. I did think of adding a "sequence number" so you could sort events based on that (e.g. event 1 of n) but eventTime is probably an easier way to reason about it!

@ungn ungn removed their assignment Jun 5, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants