Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All models: Make sessions_to_include step in base module deterministic #96

Open
bill-warner opened this issue May 14, 2021 · 1 comment

Comments

@bill-warner
Copy link
Contributor

Currently sessions greater in length than days_late_allowed (default 3 days) will be included/excluded depending on the update cadence of the model. This is undesirable as the model should be deterministic.

I believe this issue affects both web and mobile models.

Suggested fix.

This fix is yet to be thoroughly tested.

@colmsnowplow
Copy link
Collaborator

The suggested fix link leads to the front page of the repo - here's the actual commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants