Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loader: Quote catalog and schema names in SQL statements #1143

Closed
istreeter opened this issue Dec 1, 2022 · 2 comments
Closed

Loader: Quote catalog and schema names in SQL statements #1143

istreeter opened this issue Dec 1, 2022 · 2 comments

Comments

@istreeter
Copy link
Contributor

We got this error from a Databricks loader when the catalog has a hyphen:

Possibly unquoted identifier test-catalog-name detected. Please consider quoting it with back-quotes as test-catalog-name(line 1, pos 31)
voropaevp added a commit that referenced this issue Dec 1, 2022
@voropaevp
Databricks: Quote catalog and schema names in SQL statements (close #…
e323b8e 
…1143)
voropaevp added a commit that referenced this issue Dec 1, 2022
@voropaevp
Databricks: Quote catalog and schema names in SQL statements (close #…
6fd6e71 
…1143)
voropaevp added a commit that referenced this issue Dec 1, 2022
@voropaevp
Databricks: Quote catalog and schema names in SQL statements (close #…
4bfe0ff 
…1143)
@voropaevp voropaevp changed the title Databricks: Quote catalog and schema names in SQL statements Loader: Quote catalog and schema names in SQL statements Dec 1, 2022
@voropaevp
Copy link
Contributor

We should extend this to other loaders.

voropaevp added a commit that referenced this issue Dec 1, 2022
@voropaevp
Loaders: Quote catalog and schema names in SQL statements (close #1143)
8ed4b9b
voropaevp added a commit that referenced this issue Dec 1, 2022
@voropaevp
Loaders: Quote catalog and schema names in SQL statements (close #1143)
c049834
@spenes
Copy link
Contributor

spenes commented Dec 21, 2022

We've decided it would be better to restrict character set instead. Closing this one.

@spenes spenes closed this as completed Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@istreeter @voropaevp @spenes