Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dhtnode and dhtdump binaries should be installed to /usr/bin not /usr/sbin #151

Open
joseph-wakeling-sociomantic opened this issue Aug 14, 2018 · 6 comments

Comments

@joseph-wakeling-sociomantic
Copy link
Contributor

The current dhtnode.pkg spec installs the dhtnode and dhtdump binaries to /usr/sbin, which is reserved for system binaries; they should be installed into /usr/bin where ordinary command binaries live.

This will require tweaking both the .pkg file and the systemd service files.

@joseph-wakeling-sociomantic
Copy link
Contributor Author

The same issue applies to dmqnode and dlsnode; I'll leave it to you to decide if you care about opening separate issues.

@gavin-norman-sociomantic

Luca was the one who made this decision, originally, so I trust that there was some logic behind it.

I heard a rumour that usr/sbin is for apps that require sudo permissions.

@joseph-wakeling-sociomantic
Copy link
Contributor Author

I heard a rumour that usr/sbin is for apps that require sudo permissions.

Yes, that matches my understanding. Does dhtnode require those permissions?

@gavin-norman-sociomantic

Yes. As far as I remember, locking its memory into RAM requires this.

@joseph-wakeling-sociomantic
Copy link
Contributor Author

Ah, that makes sense. Well, let's wait for @leandro-lucarella-sociomantic's pronouncement, but that sounds like a reasonable basis for the decision.

@nemanja-boric-sociomantic
Copy link
Contributor

This is handled by

LimitMEMLOCK=infinity:infinity
so there's no need for root.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants