Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GetHashRange all-finished notifier should not log an error #121

Open
gavin-norman-sociomantic opened this issue Mar 8, 2018 · 0 comments

Comments

@gavin-norman-sociomantic

Currently, when a GetHashRange request finishes, it logs an error: https://github.com/sociomantic-tsunami/dhtproto/blob/neo/src/dhtproto/client/request/internal/GetHashRange.d#L185

This is not always an error, though, as the client might have been shut down deliberately by the user, which would cause this request to end.

A better solution might be to add a new notification type to the connection notifier.

@gavin-norman-sociomantic gavin-norman-sociomantic added this to the neo-alpha-6 milestone Apr 18, 2018
@gavin-norman-sociomantic gavin-norman-sociomantic removed this from the neo-v0.7.0 milestone Jul 18, 2018
@gavin-norman-sociomantic gavin-norman-sociomantic added this to the neo-v0.8.0 milestone Aug 3, 2018
@gavin-norman-sociomantic gavin-norman-sociomantic modified the milestones: neo-v0.10.0, neo-v0.9.0 Nov 15, 2018
@matthias-wende-sociomantic matthias-wende-sociomantic modified the milestones: neo-v0.9.0, neo-v0.10.0 Nov 23, 2018
@gavin-norman-sociomantic gavin-norman-sociomantic removed this from the neo-v0.10.0 milestone Dec 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants