Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make use of the swarm's useNode failure return value #186

Open
nemanja-boric-sociomantic opened this issue Nov 8, 2018 · 0 comments
Open

Comments

@nemanja-boric-sociomantic
Copy link
Contributor

swarm's useNode [1] will be enhanced with the different error code for the cases where the node is not in the connection set and when the node is not currently connected (but it was). dhtproto single node requests (Put, Get, Exists, Remove) should check this exit code and in case of the latter, send node_disconnected instead of no_node error [2] to the user.

[1] sociomantic-tsunami/swarm#372
[2]

https://github.com/sociomantic-tsunami/dhtproto/blob/neo-v0.x.x/src/dhtproto/client/internal/NodeHashRanges.d#L205

@nemanja-boric-sociomantic nemanja-boric-sociomantic added this to the neo-v0.9.0 milestone Nov 8, 2018
@gavin-norman-sociomantic gavin-norman-sociomantic modified the milestones: neo-v0.10.0, neo-v0.9.0 Nov 15, 2018
@matthias-wende-sociomantic matthias-wende-sociomantic modified the milestones: neo-v0.9.0, neo-v0.10.0 Nov 23, 2018
@gavin-norman-sociomantic gavin-norman-sociomantic removed this from the neo-v0.10.0 milestone Dec 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants