-
Notifications
You must be signed in to change notification settings - Fork 414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust OpenTelemetry metric names, add require attributes #4057
Labels
Comments
adamw
changed the title
Adjust opentelemetry metric names, add require attributes
Adjust OpenTelemetry metric names, add require attributes
Oct 16, 2024
/bounty $500 |
💎 $500 bounty • SoftwareMillSteps to solve:
Thank you for contributing to softwaremill/tapir! |
You can use OpenTelemetry semantic conventions to generate specs and use them in tests to ensure all required attributes are in place. Here are a few examples:
|
/attempt #4057 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently
OpenTelemetryMetrics
reports metrics with names inherited from the Prometheus integration.We should adjust this to conform to the recommended naming as specified by OpenTelemetry docs.
Moreover, alongside the metrics, we should report the required attributes; if optional attributes are feasible and make sense, they should be included as well.
Strict binary/source compatibility is not required, however we should aim at keeping the changes to the necessary minimum, as well as documenting migration path.
The text was updated successfully, but these errors were encountered: