Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust OpenTelemetry metric names, add require attributes #4057

Open
adamw opened this issue Sep 23, 2024 · 4 comments
Open

Adjust OpenTelemetry metric names, add require attributes #4057

adamw opened this issue Sep 23, 2024 · 4 comments

Comments

@adamw
Copy link
Member

adamw commented Sep 23, 2024

Currently OpenTelemetryMetrics reports metrics with names inherited from the Prometheus integration.

We should adjust this to conform to the recommended naming as specified by OpenTelemetry docs.

Moreover, alongside the metrics, we should report the required attributes; if optional attributes are feasible and make sense, they should be included as well.

Strict binary/source compatibility is not required, however we should aim at keeping the changes to the necessary minimum, as well as documenting migration path.

@adamw adamw changed the title Adjust opentelemetry metric names, add require attributes Adjust OpenTelemetry metric names, add require attributes Oct 16, 2024
@adamw
Copy link
Member Author

adamw commented Oct 16, 2024

/bounty $500

Copy link

algora-pbc bot commented Oct 16, 2024

💎 $500 bounty • SoftwareMill

Steps to solve:

  1. Start working: Comment /attempt #4057 with your implementation plan
  2. Submit work: Create a pull request including /claim #4057 in the PR body to claim the bounty
  3. Receive payment: 100% of the bounty is received 2-5 days post-reward. Make sure you are eligible for payouts

Thank you for contributing to softwaremill/tapir!

Add a bountyShare on socials

@iRevive
Copy link

iRevive commented Oct 16, 2024

we should report the required attributes

You can use OpenTelemetry semantic conventions to generate specs and use them in tests to ensure all required attributes are in place.

Here are a few examples:

@mobley-trent
Copy link

/attempt #4057

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants