Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If a symlink points to a subdirectory within the same directory, the parent cannot be opened #60

Open
KaiRo-at opened this issue Oct 4, 2014 · 1 comment

Comments

@KaiRo-at
Copy link

KaiRo-at commented Oct 4, 2014

With the current images for the Firefox OS Flame, aafm cannot open the root directory of the device.

The issue comes down to this:

root@flame:/ # ls -l storage/
drwxrwxr-x root sdcard_rw 1970-01-01 01:00 sdcard
lrwxrwxrwx root root 1970-01-08 22:57 sdcard0 -> /storage/sdcard

So, as that symlink points into the same directory it is in, the call in https://github.com/sole/aafm/blob/master/src/Aafm.py#L134 creates an endless loop and the parent of /storage (i.e. /) cannot be opened in aafm at all.
I work around this by just locally changing that line to |is_directory = False| but that's obviously not the right fix. ;-)

@sole
Copy link
Owner

sole commented Oct 6, 2014

Patches welcome ;)

meighti pushed a commit to meighti/aafm that referenced this issue May 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants