Skip to content
This repository has been archived by the owner on Sep 29, 2023. It is now read-only.

Move the training loop boilerplate code #7

Open
jason-fries opened this issue May 7, 2021 · 1 comment
Open

Move the training loop boilerplate code #7

jason-fries opened this issue May 7, 2021 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@jason-fries
Copy link
Contributor

Currently the training loop is in ehr_ml/blob/master/ehr_ml/clmbr/__init__.py. Training should be external to the specific model choice to better support other architecture choices and hook into existing training/tunining frameworks like Ray Tune, pytorch lightning

@jason-fries jason-fries added the enhancement New feature or request label May 7, 2021
@woffett
Copy link
Contributor

woffett commented May 21, 2021

I moved the training loop to ehr_ml/clmbr/featurizer inside a .fit method. Not exactly external to the model (actually kind of built-in to the featurizer class now) but in the featurizer class does build the model based on the config, so in that sense this kind of accomplishes the goal of model-agnostic training code?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants