Erroneous node displayed

[tew]

Hello.

When displaying data when using a simple network with a gateway and one node, it appears that some informations from the gateway may be displayed on the detail panel of the node.

The gateway and nodes are defined like:
Gateway / node0:

• slot 0 = dimmable light
• slot 2 = pressure sensor

Node 1:

• slot 0 = temperature sensor
• slot 2 = humidity sensor

The issue is that when I look at the second node, I see the pressure sensor values from the first node instead of the humidity values!

If I force the pressure sensor on node 0 to update its values each second,
I even see always that pressure on node 1/slot2 instead of the humidity value.

PleasSo I have 2 nodes, detailed here:
Gateway / node0:

• slot 0 = dimmable light
• slot 2 = pressure sensor

Node 1:

• slot 0 = temperature sensor
• slot 2 = humidity sensor

Everything was fine until today.
I use the android app to watch values.

But sometimes, when I look at the second node, I see the pressure sensor values from the first node instead of the humidity values!

If I force the pressure sensor on gateway node to update its values each second,
When I look at the detail panel of node 1, the correct value - humidity - appears briefly sometimes, but is most of the time replaced by the pressure from the gateway node.

You will find attached the 2 sketches to demonstrate the issue.
gateway.txt
node1.txt

The issue was already discussed in the souliss forum, in this thread:
https://groups.google.com/forum/#!topic/souliss/7UWuvrFQyi4

Have a nice day!

Sylvain

[tew]

To illustrate the issue, here is a screen capture when displayiong the second node.
You can see the second device - an humidity captor - with the value of the pressure (2428) from the first node instead of humidity.

Regards,

Sylvain

[shineangelic]

could you post a screen of UDP test option after pressing "TYPREQ" ? thank you

this bug is so weird

[tew]

Hello!
I'll try to do that on this week-end

[tew]

Hi!

Here is the screenshot. I hope this can help!

[shineangelic]

@plinioseniore could you have a look at this? the typrequest seems strange to me, for sure the app is receiving more than two nodes...

this bug is interesting somehow, I never heard of structure requests bug...
@tew do you have root access on your phone? To go deep, I'd probably need your DB file, that is located at /data/data/it.angelic.soulissclient/databases/

you can send that privately, even tho it doesn't contain strictly personal data, nor your IP addresses

[tew]

@shineangelic I'm sorry I should have told this before, but my network now contains more than 2 nodes indeed. They are 4 nodes.
However this issue also occurs with 2 nodes.

At the first post on this bug, there code source with 2 nodes to demonstrate it.
I don't think my setup is particular.

I think the bug occurs when receiving data from the first node, while displaying the second node on soulissapp. Would you be able to reproduce the setup given below? If not I can try to do this for you. Let me know.

[plinioseniore]

@shineangelic there are multiple 0x31 notification that refers always to the same node (the 0x0) and are 0x19 bytes long. Nothing strange here. @tew Have you extended the number of slots from 24 to 25?

[tew]

Yes, I've changed the number of slots.

I've made a new test, with two very basic nodes.
Gateway, ethernet 192.168.1.70, 1 slot with a T58 (pressure, sent every 7 seconds)
Node1, ethernet, 192.168.1.71: 1 slot with a T52 (temperature, sent every 10 seconds)

With soulissapp, I look the node1. Sometimes the slot displays a temperature, which is right, sometimes a pressure, which is wrong, since it comes from the gateway node.

Here are the screens:

As you can see, both screen shots display a T52 slot, I'm on the node1, indeed.

Here is also a TYPREQ:

I used this source code for gateway/node:

issue137.zip

Is there anything else I can do to help you?
Maybe installing a custom APK? I'm not root on my phone.

[tew]

One last thing: the souliss code I use is a fresh clone from github, branch friariello, commit 5e0af6d419076f4c0a504754cbfc7c3c8193b1d9.

[plinioseniore]

The log shows updates from either node 0x0 and 0x1, seems that SoulissApp doesn't process correctly the node number while updating data. @shineangelic could you please see how SoulissApp behave in this scenario?

[shineangelic]

The code handling souliss udp replies hasn t be touched from a loong time, i told you this is so weird...that code is part of sapp core, how can such a huge bug still be there? I never noticed a behaviour like this, but something has to be wrong, indeed. I have to replicate the bug with adb connected, so i can go deep and find it...sadly i dont have board available for testing right now...@tew do you think you could TEMPORANELY give public access to your boards? Ale Il 30 gen 2017 22:52, "Dario Di Maio" <[email protected]> ha scritto:

…

The log shows updates from either node 0x0 and 0x1, seems that SoulissApp doesn't process correctly the node number while updating data. @shineangelic could you please see how SoulissApp behave in this scenario? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#137 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABRfdP35XS_XepUkiWaj0YdSNFNm6N8Kks5rXluUgaJpZM4JI5wK> .

[plinioseniore]

@shineangelic could be the bind between graphic and db?

[shineangelic]

mmm not probable. We'd have noticed some weird behaviour before. Key to update typicals is given by nodeID + slot. It has always been like this... Maybe it could be related to T58, poorly tested, but I can't see what Ale 2017-01-31 7:53 GMT+01:00 Dario Di Maio <[email protected]>:

…

@shineangelic could be the bind between graphic and db? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#137 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABRfdCAPNCpDl4hEzZ73hwPxKKxpppnHks5rXtqGgaJpZM4JI5wK> .

[shineangelic]

anyway, this is the relevant piece of code. It always worked and I don't think the problem is here

for (short j = 0; j < numberOf; j++) {
                try {
                    SoulissNode it = nodes.get(((int) j / typXnodo) + tgtnode);
                    SoulissTypical temp = it.getTypical((short) (j % typXnodo));
                    SoulissTypicalDTO dto = temp.getTypicalDTO();
                    dto.setOutput(mac.get(5 + j));
                    dto.setSlot(((short) (j % typXnodo)));
                    dto.setNodeId((short) (j / typXnodo + tgtnode));
                    // sufficiente una refresh
                    dto.refresh(temp);
                    Log.d(Constants.Net.TAG, "---REFRESHED NODE:" + (j / typXnodo + tgtnode) + " SLOT:" + (j % typXnodo));
                } catch (NotFoundException e) {
                    // skipping unexistent typical");
                    //OK, può succedere
                } catch (Exception e) {
                    Log.w(Constants.Net.TAG, "Errore di calcolo??" + e.getMessage());
                    // FIXME nodes.get(((int) j / typXnodo) + tgtnode) è SBAGLIATO l'ha detto Dario
                }
            }

[shineangelic]

on the log file, when app receives update, the log (/sdcard/souliss.log) will report exactly which node has been updated.

@tew what's your maxTypicalXnode setting ? You can see it when you request DB structure, it's the 7th byte

[tew]

I looked at the file /sdcard/souliss.log but it has not been updated since november. Should delete it? Is it stored in another place?

How can I request the DB structure?

[shineangelic]

@plinioseniore can't be the UI binding, because the unit measure is C degrees, not pascal. So a T52 is being shown for sure.

I bet the wrong value 1072 is being saved on DB, it comes from there.

I really need to replicate this in debug.

@tew you log is dated november because you had no application error, and in production/release mode, log only shows errors and warnings, not debug messages

[plinioseniore]

@shineangelic it would be better to let @tew use SoulissApp in debug mode.