Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: TypeScript typecheck job is not catching type errors #113

Open
olafurpg opened this issue Oct 25, 2022 · 0 comments
Open

CI: TypeScript typecheck job is not catching type errors #113

olafurpg opened this issue Oct 25, 2022 · 0 comments
Assignees
@varungandhi-src
Labels
graph/scip team/graph

Comments

@olafurpg
Copy link
Member

I was updating scip-typescript to use the latest copy of scip.ts and found a regression where this file no longer typechecks successfully. I was able to fix the problem by downgrading our protoc generator version in #112

This issue is a followup to identify why the typecheck CI job didn't fail when we bumped up the version of the protoc generator
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@varungandhi-src varungandhi-src

Labels
graph/scip team/graph
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@olafurpg @varungandhi-src