fix: skip exported symbols with no definition #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bindings/go/scip/convert.go
Outdated
Comment on lines
112
to
113
| // TODO: We could instead pass back a list of warnings to be displayed by callers? | ||
| // I don't really like just printing to stdout here (additionally, these could be coallesced between documents) |
There was a problem hiding this comment.
I agree, we shouldn't be printing to stdout here. For example, having this output in src CLI would not be useful when looking at logs. Instead, any I/O should be happening within scip CLI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #60
Test plan