Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data model class for Taxon Attribute is incorrect #1229

Open
grantfitzsimmons opened this issue Oct 18, 2023 · 2 comments · May be fixed by specify/specify7#5367
Open

Data model class for Taxon Attribute is incorrect #1229

grantfitzsimmons opened this issue Oct 18, 2023 · 2 comments · May be fixed by specify/specify7#5367
Assignees

Comments

@grantfitzsimmons
Copy link
Member

grantfitzsimmons commented Oct 18, 2023

Describe the bug
Even though a form is defined to show up under the Taxon Attribute table, it is showing up under Collection Object Attribute and not Taxon Attribute.

See below: (https://nbmmnb5523-xml-editor.test.specifysystems.org/specify/resources/view-set/2/CollectionObjectAttribute/TaxonAttributes)

In the XML editor:

image
<viewdef type="form" name="TaxonAttributes" class="edu.ku.brc.specify.datamodel.TaxonAttribute" gettable="edu.ku.brc.af.ui.forms.DataGetterForObj" settable="edu.ku.brc.af.ui.forms.DataSetterForObj">
			<desc>Form For taxon Attribute</desc>

In the Visual Editor:

image image image

❓ ❗

@grantfitzsimmons grantfitzsimmons changed the title xml-editor: Form for Taxon Attribute is showing up under Collection Object Attribute Data model class for Taxon Attribute is incorrect Oct 18, 2023
@CarolineDenis CarolineDenis self-assigned this Oct 18, 2023
@grantfitzsimmons
Copy link
Member Author

It looks like the global.views.xml that we ship currently has an incorrect <view>, where it shows:

class="edu.ku.brc.specify.datamodel.CollectionObjectAttribute"

This is what is making it show up there.

<view name="TaxonAttributes"
class="edu.ku.brc.specify.datamodel.CollectionObjectAttribute"
resourcelabels="false">
<desc><![CDATA[Subform within the Collection Object form.]]></desc>
<altviews>
<altview name="TaxonAttributes View" viewdef="TaxonAttributes" mode="view"/>
<altview name="TaxonAttributes Edit" viewdef="TaxonAttributes" mode="edit" default="true"/>
</altviews>
</view>

        <view name="TaxonAttributes"
            class="edu.ku.brc.specify.datamodel.CollectionObjectAttribute"
            resourcelabels="false">
            <desc><![CDATA[Subform within the Collection Object form.]]></desc>
            <altviews>
                <altview name="TaxonAttributes View" viewdef="TaxonAttributes" mode="view"/>
                <altview name="TaxonAttributes Edit" viewdef="TaxonAttributes" mode="edit" default="true"/>
            </altviews>
        </view>

@grantfitzsimmons grantfitzsimmons transferred this issue from specify/specify7 Oct 18, 2023
grantfitzsimmons added a commit to specify/specify7 that referenced this issue Nov 6, 2024
@grantfitzsimmons
Copy link
Member Author

Solved in specify/specify7@c9e509d

@grantfitzsimmons grantfitzsimmons linked a pull request Nov 6, 2024 that will close this issue
36 tasks
@grantfitzsimmons grantfitzsimmons linked a pull request Nov 7, 2024 that will close this issue
36 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

2 participants