Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address static file issues #5310

Closed
grantfitzsimmons opened this issue Oct 4, 2024 · 0 comments
Closed

Address static file issues #5310

grantfitzsimmons opened this issue Oct 4, 2024 · 0 comments
Assignees
Labels
1 - Bug Incorrect behavior of the product type:housekeeping Code cleanup and refactoring
Milestone

Comments

@grantfitzsimmons
Copy link
Member

We need to address a number of comments from @melton-jason left on the #5266 PR that we could not resolve before it was merged.

#5266 (review)

Good work so far!

It'd be great if we can get around to fixing some of the past Issues we've had with the default forms!

From the ones I can find/remember:

#4591
#3120
#364
#5073
#1254
#4737

Besides that, since there is a lot of duplication for each discipline, I've only left a single comment for each type of app resource in a single discipline. Any comments on a type of app resource should apply anywhere it appears.
If there are no comments on a type of app resource, that means I found usages of the app resource in Specify 7 and it should be kept.

Need to fold in all of the comments in this review and respond to them.

@grantfitzsimmons grantfitzsimmons added 1 - Bug Incorrect behavior of the product type:housekeeping Code cleanup and refactoring labels Oct 4, 2024
@grantfitzsimmons grantfitzsimmons added this to the 7.9.8 milestone Oct 4, 2024
@grantfitzsimmons grantfitzsimmons self-assigned this Oct 4, 2024
@grantfitzsimmons grantfitzsimmons closed this as not planned Won't fix, can't repro, duplicate, stale Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 - Bug Incorrect behavior of the product type:housekeeping Code cleanup and refactoring
Projects
None yet
Development

No branches or pull requests

2 participants