Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug with group meshes #102

Closed
oguzhankoral opened this issue Dec 13, 2022 · 2 comments · Fixed by #104
Closed

Bug with group meshes #102

oguzhankoral opened this issue Dec 13, 2022 · 2 comments · Fixed by #104
Assignees
@oguzhankoral
Labels
bug Something isn't working
Milestone
2.11

Comments

@oguzhankoral
Copy link
Member

oguzhankoral commented Dec 13, 2022 •
edited
Loading

This bug reported via community under the post. Main problem is grouping meshes according to their materials when they are under the group or component. Instead group meshes, theoratically we should send them separately because when we receive back they will be handled as separate objects. And also realized that currently we do not send orphan edges (edge that does not involve any face) in the group.

PS: Performance should be checked.
@oguzhankoral oguzhankoral added the bug Something isn't working label Dec 13, 2022
@oguzhankoral oguzhankoral added this to the 2.11 milestone Dec 13, 2022
@oguzhankoral oguzhankoral self-assigned this Dec 13, 2022
@oguzhankoral
Copy link
Member Author

Regardless of this issue, when SketchUp have face that have more than one pieces that are disconnected, causes below mesh problem.

face_disconnection

image

@oguzhankoral
Copy link
Member Author

Self intersecting is detected.

self_intersecting_face

@oguzhankoral oguzhankoral mentioned this issue Dec 13, 2022
Closed
@oguzhankoral oguzhankoral linked a pull request Dec 13, 2022 that will close this issue
Feat (Group): Send meshes separately under the group #104
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oguzhankoral oguzhankoral

Labels
bug Something isn't working
Projects
None yet
Milestone
2.11
Development

Successfully merging a pull request may close this issue.

Feat (Group): Send meshes separately under the group specklesystems/speckle-sketchup
1 participant
@oguzhankoral