Best-effort error reporting for interactions on final methods #2040
+437
−54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2040 +/- ##
============================================
+ Coverage 80.44% 81.94% +1.49%
- Complexity 4337 4643 +306
============================================
Files 441 450 +9
Lines 13534 14509 +975
Branches 1707 1836 +129
============================================
+ Hits 10888 11889 +1001
+ Misses 2008 1943 -65
- Partials 638 677 +39 ☔ View full report in Codecov by Sentry. |
Add error reporting code to the byte-buddy` mock maker to report interaction on final methods, which can't be handled. The IMockInteractionValidation interface allows IMockMakers to implement different kinds of validations on mock interactions. Fixes spockframework#2039
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add error reporting code to the byte-buddy` mock maker to report interaction on final methods, which can't be handled.
The IMockInteractionValidation interface allows IMockMakers to implement different kinds of validations on mock interactions.
Fixes #2039