Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating packages SPK from wheels with '.data' directory results in missing files #40

Closed
bbassett-tibco opened this issue Apr 22, 2023 · 1 comment

Comments

@bbassett-tibco
Copy link
Collaborator

When a packages SPK is being built (using python -m spotfire.spk packages pkg.spk req.txt) using wheels that have a .data directory (for example, xgboost version 1.7.5 on Windows) results in an SPK file that does not contain the Python files from the wheel (it just contains the files from the .data directory).

bbassett-tibco added a commit that referenced this issue Apr 24, 2023
It's no longer required, and can cause problems with some packages (like 'xgboost' on Windows).
@bbassett-tibco
Copy link
Collaborator Author

It looks like the combination of --upgrade and --target to pip install is not well supported. pypa/pip#8063 looks like the underlying issue in our case, with the exception that the directory being replaced is not bin (as in the pip issue), but xgboost's main python files being replaced by xgboost's .data directory.

Lucklily, we no longer depend on the parsing of pip output during the assembly of SPK packages to determine installed Python package versions (as a result of work done in cb55cee). (The --upgrade option was specified to silence a warning from pip from appearing on the last line of the output, and confusing the SPK versioning update logic.) Removing the --upgrade option from pip calls creates the proper SPK package contents, but will expose the pip warning to the user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant