Allow load balancer uri in uri attribute #518
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 30, 2021 18:05
By specifing 'lb://' protocol, feign client factory will use load balance client instead of using delegate client Closes #489
Codecov Report
@@ Coverage Diff @@
## master #518 +/- ##
============================================
+ Coverage 77.85% 78.41% +0.55%
- Complexity 489 499 +10
============================================
Files 60 60
Lines 1820 1816 -4
Branches 267 266 -1
============================================
+ Hits 1417 1424 +7
+ Misses 256 249 -7
+ Partials 147 143 -4
|
|
Are you sure it's related to 499? Doesn't seem like it is to me... |
|
@Sam-Kruglov Yeah sorry. Thank you for the warning. 🙏 |
|
See #489 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #489 : This change is the one requested by late issue . The aim is to handle url such as
lb://some-service(or `lbs://some-service). When such url is specified, we ensure load balance client is provided and we keep it instead of using delegate one).Code implementation
I willingly kept 3 commit to better describe the implementation
name,urlandpathhandle by adding testsurlwas modified by side effect)