Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing query options when calling MongoTemplate#findAndModify #4778

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

sriram-1729
Copy link

Forward maxTimeMsec from Query to FindOneAndUpdateOptions.

Closes #4776

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Sep 5, 2024
@sriram-1729 sriram-1729 changed the title Fix missing query options when calling MongoTemplate#findAndModify #4776 Fix missing query options when calling MongoTemplate#findAndModify Sep 5, 2024
@christophstrobl
Copy link
Member

Thank you @sriram-1729 for taking the time to create this PR.
The signature change of doFindAndModify may cause trouble for people upgrading. I'm not sure if there's away around this change. Need to have a closer look.

@sriram-1729
Copy link
Author

Hello @christophstrobl! In case the method signature change is allowed, should I keep the changes minimal, or can I make further modifications to remove redundant arguments?

@christophstrobl christophstrobl added the for: team-attention An issue we need to discuss as a team to make progress label Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
for: team-attention An issue we need to discuss as a team to make progress status: waiting-for-triage An issue we've not yet triaged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

maxTimeMs in MongoTemplate.findAndModify(...) is not being honored.
3 participants