Skip to content

Latest commit

 

History

History
19 lines (19 loc) · 1.11 KB

pr-template.md

File metadata and controls

19 lines (19 loc) · 1.11 KB
Raw

What's this PR do?

Where should the reviewer start?

How should this be manually tested?

Any background context you want to provide?

What are the relevant tickets?

Screenshots (if appropriate)

What gif best describes this PR or how it makes you feel?

Definition of Done:

  • Is there appropriate test coverage? (e.g. ChefSpec, Mocha/Chai, Python, etc.)
  • Does this PR require a Selenium test? (e.g. Browser-specific bugs or complicated UI bugs)
  • Does this PR require a regression test? All fixes require a regression test.
  • Does this PR require a blog post? If so, ensure marketing has signed off on content.
  • Does the knowledge base need to be updated?
  • Does this add new dependencies? If so, does Chef, M4, or PIP requirements need to be updated?
  • Will this feature require a new piece of infrastructure be implemented?
  • Are any new services fully automated in Chef?
  • Are there ChefSpec tests for the new Chef recipes/cookbooks?
  • Does this PR require new Mixpanel or GA events?
  • Is there appropriate logging included?