Skip to content
This repository has been archived by the owner on Aug 18, 2021. It is now read-only.

Train and Test Split #124

Open
rjtmehta99 opened this issue Jan 16, 2019 · 1 comment
Open

Train and Test Split #124

rjtmehta99 opened this issue Jan 16, 2019 · 1 comment

Comments

@rjtmehta99
Copy link

In the Char RNN classification I had some questions:

  1. Why have not split the dataset into train and test/validation set to check the performance ?
  2. How can we add 'accuracy' as a metric to evaluate model performance ?
@masalha-alaa
Copy link

masalha-alaa commented Aug 4, 2021

I agree with this. Currently he tests on the training data, and draws a misleading confusion matrix. He trains on 100K names with repetitions, and tests against 10K from the same population, yet again with repetition. You can't infer accuracy from this. You need to split to train / test and evaluate on the test after every epoch. Please see my notebook.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants