-
-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve handling of prepend_sys_path, fixes #1330 #1331
base: main
Are you sure you want to change the base?
Conversation
Don't split using colons on windows Fixes sqlalchemy#1330
Can someone please give brief guidance on how to create a test for this. |
I would use |
also wired that space is considered a separator, since a path can have a space in it. @zzzeek do you remember the reason? |
There was a complex legacy arrangement here when the path separator system was first introduced, so I would look at the history there to see what our default separator used to be etc. |
I like using Am I good to just remove splitting on whitespace altogether? |
hi there, and sorry, I looked at what we are actually doing here. This is a new use case, and it looks like prepend_sys_path was very unfortunately glossed over when we added configurable path separators. So we have the same legacy situation where we should not have a loosely defined scheme like this. I propose we add another new config attribute Taht is like this:
|
I replaced the earlier implementation with a new one that does what @zzzeek described. Haven't tried it yet though, will do that on Monday |
this would need some tests to move along. it's a year later so I'd have to look closely again at this to see what we're doing (sorry I dont have a good memory) |
Description
os.name
equals'nt
' then don't split using colons' '
character so people can break up long lists into multiple lines.Fixes: #1330
How should I test this?
Checklist
This pull request is:
must include a complete example of the issue. one line code fixes without an
issue and demonstration will not be accepted.
Fixes: #<issue number>
in the commit messageinclude a complete example of how the feature would look.
Fixes: #<issue number>
in the commit message