-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Possibly center debug indicators? #791
Possibly center debug indicators? #791
Comments
Debug indicators are not applied to the image. They are drawn in the corner of a custom |
Makes sense. Yet, when I use centerCrop(), indicators don't show (2.4.0). Code used: <ImageView
android:id="@+id/image"
android:layout_width="match_parent"
android:layout_height="match_parent" /> Picasso.setSingletonInstance(new Picasso.Builder(this.getApplicationContext()).indicatorsEnabled(true).build());
Picasso.with(StuffdApp.getAppInstance()).load(url).fit().centerCrop().skipMemoryCache().error(R.drawable.ic_5_content_remove); |
We used to tint the whole image. I think it's a bit extreme. Not sure how I |
This one was totally my fault. Have a framelayout going on and something else was covering a top strip of an image. Still +1 for a centered indicator :) |
+1 (Or at least having option to choose a different location). We have images that already have something over the corner and those cover up the debug indicators. |
+1 |
A center indicator will be great. Like @andrewlord1990 , I have something covering the top left of my images. |
I have the similar problem, If I use an ImageView with circular borders, I do not see indicators. If we can configure the position of the indicators, It will be great. |
Is there a way to center the indicator? |
@ghuiii AFAIK, nope. |
PR welcome |
@JakeWharton I want to work on this. When the indicators are centered we will have a round circle in middle of the image view just like the image below which is the result of my current implementation. Any suggestion or can I go for it ? |
This reverts commit dd51ed9.
In too many places picasso is used with centerCrop() which makes debug indicators invisible (cropped out). And one more scenario: using RoundedImageView also hides the indicator. Having it in the center would fix these kinds of problems. Just making my case :)
The text was updated successfully, but these errors were encountered: