Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify Sample Size a Bit More Clearly #198

Open
ParadaCarleton opened this issue Mar 19, 2022 · 2 comments
Open

Specify Sample Size a Bit More Clearly #198

ParadaCarleton opened this issue Mar 19, 2022 · 2 comments

Comments

@ParadaCarleton
Copy link

The current phrasing contains the same information but is a bit harder to interpret:

Computed from 4000 by 262 log-likelihood matrix

ParetoSmooth.jl is more explicit about this, with a phrasing that mentions "n observations and m posterior samples." I've found this prevents mistakes -- it's very common for users to accidentally misspecify what it is they want to leave out, e.g. by placing all their observations in one multivariate normal, which causes confusion when the whole dataset is left out. I think this might be a more useful message.

@jgabry
Copy link
Member

jgabry commented Mar 21, 2022

Hey Carlos, yeah we could be more clear about the posterior samples vs observations. Thanks for the suggestion.

@avehtari
Copy link
Collaborator

I started to make a PR for this, but there is a challenge that the second dimension (here 262) is not necessary the number of observations, as we can leave out more than one observation, and there is no way loo package can infer that. How about

Computed from 4000 posterior draws by 262 log-likelihood terms matrix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants