Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: model_base methods - use Eigen::Ref<Eigen::VectorXd> #3289

Open
andrjohns opened this issue May 23, 2024 · 0 comments
Open

FR: model_base methods - use Eigen::Ref<Eigen::VectorXd> #3289

andrjohns opened this issue May 23, 2024 · 0 comments

Comments

@andrjohns
Copy link
Contributor

Summary:

The Eigen overloads for model base methods like log_prob and unconstrain_array only accept Eigen::VectorXd inputs, which can require some data-reshaping/copying for downstream interfaces.

If these could be changed to Eigen::Ref<Eigen::VectorXd> (or overloads for these added), then the current Stan behaviour would be unchanged but interfaces could then pass Eigen::Map<Eigen::VectorXd> types and avoid extra copies

Current Version:

v2.35.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant