Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking Revert of PR #37 #42

Closed
thearossman opened this issue Sep 4, 2024 · 1 comment
Closed

Tracking Revert of PR #37 #42

thearossman opened this issue Sep 4, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@thearossman
Copy link
Collaborator

(Since AFAIK Github doesn't let you re-open a merged and reverted PR)

I just reverted #37 (#37) because it broke compilation on ARM machines. Details are here: #41

I worked on this for a bit and couldn't find a relatively quick fix (e.g., replacement library with same API) -- we'd need to find a different library with equivalent functionality.

@sippejw tagging you so that you're aware this got reverted! As I think you're the primary one using these extra rust-crypto features, there's no rush to fix it. I can also get to it at some point.

@thearossman thearossman added the enhancement New feature or request label Sep 5, 2024
@sippejw
Copy link
Contributor

sippejw commented Sep 6, 2024

PR #55 removes the deprecated dependency and replaces it with aes-gcm which is actively maintained.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

2 participants