Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize.ts contains a lot of wrapper functions #434

Open
george1459 opened this issue Jul 28, 2022 · 0 comments
Open

optimize.ts contains a lot of wrapper functions #434

george1459 opened this issue Jul 28, 2022 · 0 comments

Comments

@george1459
Copy link

it's unclear currently why some objects have .optimize() method while some do not. Examples of some that do include: Ast.Input and Ast.BooleanExpression, while those that don't include Ast.Expression and Ast.Statement. However, it seems if an object does not have such a method, you can find a function in optimize.ts that provides the functionality. This inconsistency can be confusing to developers.

If it makes sense to add an .optimize() method for all nodes, I believe we should go ahead and do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant