Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

locationEquals in lib/runtime/primitive_ops.ts uses an arbitrary comparison distance of 2500m #451

Open
george1459 opened this issue Feb 22, 2023 · 0 comments
Open

locationEquals in lib/runtime/primitive_ops.ts uses an arbitrary comparison distance of 2500m #451

george1459 opened this issue Feb 22, 2023 · 0 comments

Comments

@george1459
Copy link

This function is triggered by __builtin.equality in the compiled code. This arbitrary number can lead to unexpected problems, such as finding restaurants on yelp.

The best solution is to support a flag in manifest.tt to disable/customize this number.

The threshold is temporarily increased in wip/geniescript
george1459 added a commit that referenced this issue Feb 22, 2023
@george1459
increase location threashold (#451)
af82312
george1459 added a commit that referenced this issue May 7, 2023
@george1459
Revert "increase location threashold (#451)"
33efcf1 
This reverts commit af82312.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@george1459