Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explictly warn/fail when an indel is encountered #84

Open
nh13 opened this issue Jan 20, 2021 · 3 comments
Open

Explictly warn/fail when an indel is encountered #84

nh13 opened this issue Jan 20, 2021 · 3 comments

Comments

@nh13
Copy link
Contributor

nh13 commented Jan 20, 2021

Currently, on the first base in the ref/alt alleles are stored and compared, which can lead to misleading results if the input VCF has indels. See this line:

allele = ( base == scl.snps[i].ref ) ? 0 : ( ( base == scl.snps[i].alt ) ? 1 : 2 );

@nh13
Copy link
Contributor Author

nh13 commented Jan 20, 2021

The current behavior is that any read will be counted towards the reference allele.

@yimmieg
Copy link
Collaborator

yimmieg commented Jan 20, 2021 via email

@nh13
Copy link
Contributor Author

nh13 commented Jan 20, 2021

Excellent! I think the main issue is that it is comparing the first base in the allele, versus the full allele from the VCF and the bases starting at the mapped position the the read.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants