Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review & rework & clean-up RLPx auth & ecies code #559

Open
kdeme opened this issue Nov 16, 2022 · 0 comments
Open

Review & rework & clean-up RLPx auth & ecies code #559

kdeme opened this issue Nov 16, 2022 · 0 comments

Comments

@kdeme
Copy link
Contributor

kdeme commented Nov 16, 2022

After fixing the crashes in #558 and looking at more detail at that code I think we should:

  • Get rid of any of the code that is there to be compatible with pre-EIP8. Geth this did this May last year here ethereum/go-ethereum@7194c84. That should make the code easier to begin with.
  • Go fully through the auth and ecies code as there might be more invalid accesses possible.
  • I think some of the size checks are not really on the right place / redundant now in ecies. Maybe not. Anyway, to be reviewed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant