test: add additional tests to utils/compact-adjacency-matrix
#1373
Conversation
kgryte
changed the title
utils/compact-adjacency-matrix
kgryte
added
Needs Review
|
Please review it. |
| var tape = require( 'tape' ); | ||
| var instanceOf = require( '@stdlib/assert/instance-of' ); | ||
| var CompactAdjacencyMatrix = require( './../lib' ); | ||
| var tape = require('tape'); |
There was a problem hiding this comment.
All of these style changes should not have been made. Please revert and ensure that you follow project conventions.
|
|
||
| tape('initialize the matrix correctly', function test(t) { | ||
| var mat = new CompactAdjacencyMatrix(4); | ||
| t.deepEqual(mat.matrix, [ |
There was a problem hiding this comment.
@uchiha-vivek Did you run these tests?
Based on what you have here, it does not appear so. There is no matrix attribute, and these tests are not written correctly.
There was a problem hiding this comment.
This PR needs significant changes in order to be merged. I encourage you to see the tests for other packages (e.g., @stdlib/array/complex64) for what we expect in terms of rigor and level of detail.
kgryte
added
Needs Changes
Planeshifter
added
the
autoclose: Stale
|
This pull request has been automatically closed because it has been inactive for an extended period after changes were requested. If you still wish to pursue this contribution, feel free to reopen the pull request or submit a new one. We appreciate your interest in contributing to stdlib! |
Resolves # .
Description
Test Cases for adjacency matrix
This pull request:
Related Issues
This pull request:
Questions
Please review the features and suggest changes if required.
Other
No.
Checklist
@stdlib-js/reviewers