Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incomplete code coverage in blas/base/dznrm2 and blas/base/scnrm2 #2543

Closed
kgryte opened this issue Jul 9, 2024 · 4 comments · Fixed by #2977
Closed

Incomplete code coverage in blas/base/dznrm2 and blas/base/scnrm2 #2543

kgryte opened this issue Jul 9, 2024 · 4 comments · Fixed by #2977
Labels
Help Wanted Extra attention is needed. Tests Pull requests specifically adding tests.

Comments

@kgryte
Copy link
Member

kgryte commented Jul 9, 2024

For context, see the coverage report posted to fcc9603#commitcomment-143981597.

Current unit tests for both blas/base/dznrm2 and blas/base/scnrm2 fail to cover all branches, resulting in less than 100% code coverage. It would be good if we could add more test cases to those packages to ensure full coverage.
@kgryte kgryte added Help Wanted Extra attention is needed. Tests Pull requests specifically adding tests. labels Jul 9, 2024
@kgryte
Copy link
Member Author

kgryte commented Jul 29, 2024

See @stdlib/lapack/base/dlassq for some ideas.

@gururaj1512
Copy link
Contributor

Working on it..!

@gururaj1512
Copy link
Contributor

@kgryte, Is there any to check coverage report before commiting and pushing?

@kgryte
Copy link
Member Author

kgryte commented Sep 20, 2024

@gururaj1512 See the development guide: https://github.com/stdlib-js/stdlib/blob/4b0d2abf2706178f83da028fc39fe0fdc3d2c073/docs/development.md#testing

@gururaj1512 gururaj1512 mentioned this issue Oct 1, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Help Wanted Extra attention is needed. Tests Pull requests specifically adding tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: completes code coverage in blas/base/dznrm2 and blas/base/scnrm2 gururaj1512/stdlib
2 participants
@kgryte @gururaj1512