[BUG]: setting seed=0 leads to non-deterministic behavior

[mglezer]

Description

I expect that setting the seed to any positive integer, including zero, should lead to deterministic behavior. This is, for example, how Python's built-in random library works. However this is not the case for @stdlib/random-shuffle; the seed seems to be silently ignored. Either seeding with zero should produce deterministic behavior, or it should fail loudly, just like with negative seed values.

Related Issues

Related issues # , # , and # .

Questions

No.

Demo

No response

Reproduction

In the node REPL:


> const shuffle = require('@stdlib/random-shuffle')
> shuffle.factory({ seed: 0 })([1,2,3])
> shuffle.factory({ seed: 0 })([1,2,3])

### Expected Results

```shell
Either

> const shuffle = require('@stdlib/random-shuffle')
> shuffle.factory({ seed: 0 })([1,2,3])
[[ SOME PERMUTATION ]]
> shuffle.factory({ seed: 0 })([1,2,3])
[[ THE SAME PERMUTATION ]]

or, throw an error and require strictly positive seeds.

### Actual Results

```shell
> const shuffle = require('@stdlib/random-shuffle')
> shuffle.factory({ seed: 0 })([1,2,3])
[ 3, 2, 1 ]
> shuffle.factory({ seed: 0 })([1,2,3])
[ 2, 3, 1 ]

### Version

0.2.1

### Environments

Node.js

### Browser Version

_No response_

### Node.js / npm Version

_No response_

### Platform

_No response_

### Checklist

- [X] Read and understood the [Code of Conduct](https://github.com/stdlib-js/stdlib/blob/develop/CODE_OF_CONDUCT.md).
- [X] Searched for existing issues and pull requests.

[stdlib-bot]

👋 Hi there! 👋

And thank you for opening your first issue! We will get back to you shortly. 🏃 💨

[kgryte]

@mglezer You're right. It seems to be due to the following line:

stdlib/lib/node_modules/@stdlib/random/shuffle/lib/factory.js

Line 66 in 7b02c16

if ( config && config.seed ) {

.

@Planeshifter Looking back through the code history, is there a reason why you wrote this to have a weak check (e.g., if ( config.seed ) {...})?

[kgryte]

@mglezer Thanks for reporting. This issue was resolved in #3007, and the patch should be made available in the next round of package releases.

cc @Planeshifter