Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

admin key can be exposed #7

Open
ddebrunner opened this issue May 24, 2024 · 1 comment · May be fixed by #8
Open

admin key can be exposed #7

ddebrunner opened this issue May 24, 2024 · 1 comment · May be fixed by #8
Assignees

Comments

@ddebrunner
Copy link
Contributor

The action uses ::add:mask:: to mask the input adminkey but this ends up logging the key, becuase there's no way in a composite action to mask values pulled from input within the action itself.

Best to remove that step and document that the caller should mask the key.

Usually this is not an issue because the key comes from GitHub secrets so it is automatically masked, but if the key came from an input on a workflow dispatch the value will be exposed.

See actions/runner#475 (comment)

@ddebrunner ddebrunner self-assigned this May 24, 2024
@ddebrunner
Copy link
Contributor Author

Also https://dev.to/leading-edje/masking-input-parameters-in-github-actions-1ci

(this technique doesn't work for actions, but it explains the problem and has additional references)

@ddebrunner ddebrunner linked a pull request May 24, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant