Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Array search does not copy indexes #11

Open
stevendesu opened this issue Nov 16, 2018 · 0 comments
Open

Array search does not copy indexes #11

stevendesu opened this issue Nov 16, 2018 · 0 comments
Labels
bug Something isn't working enhancement New feature or request MINOR This change adds new functionality, and will result in a change to the minor version

Comments

@stevendesu
Copy link
Owner

It'd be convenient if searches could be chained. For instance:

const students = Array.load(...).index();

const spanishStudents = students.search({
    language: "Spanish"
});
const maleSpanishStudents = spanishStudents.search({
    gender: "male"
});

Currently this can only be done with a 2-element search like so:

const maleSpanishStudents = students.search({
    language: "Spanish",
    gender: "male"
});

However there are legitimate use cases for being able to do these searches separately.

Note: Just like how #3 may harm performance and therefore should be added as an opt-in (or opt-out) option, this may harm performance and should be added as an opt-in / opt-out option.

@stevendesu stevendesu added bug Something isn't working enhancement New feature or request labels Nov 16, 2018
@stevendesu stevendesu added the MINOR This change adds new functionality, and will result in a change to the minor version label Nov 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request MINOR This change adds new functionality, and will result in a change to the minor version
Projects
None yet
Development

No branches or pull requests

1 participant