Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flaky on Go1.5? #9

Open
sjamesr opened this issue Sep 4, 2015 · 1 comment
Open

flaky on Go1.5? #9

sjamesr opened this issue Sep 4, 2015 · 1 comment

Comments

@sjamesr
Copy link

sjamesr commented Sep 4, 2015

Hi there,

Our continuous build started failing occasionally with the following error:

store_test.go:1111: expected concurrent set to work on key: [65], got: concurrent mutation attempted
store_test.go:1111: expected concurrent set to work on key: [50], got: concurrent mutation attempted

So far I haven't been able to reproduce on a desktop machine, but perhaps there's a race that is being exposed by changes in Go1.5?

@steveyen
Copy link
Owner

steveyen commented Sep 4, 2015

Hi @sjamesr,

You were able to get to go 1.5 before I did! :-)

One change that I read about in go 1.5 is it sets GOMAXPROCS to sometimes not 1, if you're on a multicore box, so that feels likely that might have broken some test assumptions.

Perhaps your CI system is beefier and more multi-core than your desktop box? If this is true, then one quick workaround, then, would be setting GOMAXPROCS=1 in your CI scripts and seeing if that band aids it for now?

Thanks for the report,
steve

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants